forked from space-wizards/space-station-14
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crafting menu fuzzy search framework #26
Merged
west3436
merged 4 commits into
vgstation-coders:master
from
CrazyAmphibian:uwu-fuzzywuzzy
Dec 28, 2024
Merged
crafting menu fuzzy search framework #26
west3436
merged 4 commits into
vgstation-coders:master
from
CrazyAmphibian:uwu-fuzzywuzzy
Dec 28, 2024
+44
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inorien
reviewed
Dec 27, 2024
Eneocho
added
UI
Edits UI in some way.
and removed
size/S
S: Untriaged
Changes: UI
labels
Dec 27, 2024
west3436
requested changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be consistent with naming conventions per the other comments. Let's treat this codebase with more care than we did with SS13 since we're building on a solid foundation.
literally 1984 |
i added some images |
west3436
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
adds a button for fuzzy searching and the relevant code to support it. this does not actually add any proper fuzzy search strings, but it falls back to using names so there's no errors.
Why it's good
makes the UI easier to use, doesn't require players know exact names
How it was tested
opened test server, made sure no errors
Changelog
🆑